Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/common/identity: Don't forget to refresh TLS certificate #4289

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Sep 29, 2021

No description provided.

@kostko kostko force-pushed the kostko/fix/tls-server-refresh branch from 9cd9404 to aa8a262 Compare September 29, 2021 12:11
@kostko kostko force-pushed the kostko/fix/tls-server-refresh branch from aa8a262 to 0354f88 Compare September 29, 2021 15:11
@kostko kostko marked this pull request as ready for review September 29, 2021 15:46
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #4289 (0354f88) into master (9f5a3c6) will decrease coverage by 0.69%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4289      +/-   ##
==========================================
- Coverage   69.17%   68.48%   -0.70%     
==========================================
  Files         411      411              
  Lines       47213    47213              
==========================================
- Hits        32661    32333     -328     
- Misses      10543    10837     +294     
- Partials     4009     4043      +34     
Impacted Files Coverage Δ
go/common/identity/identity.go 75.55% <100.00%> (ø)
go/ias/http/http.go 20.33% <0.00%> (-44.07%) ⬇️
go/keymanager/api/policy_sgx.go 33.33% <0.00%> (-13.34%) ⬇️
go/runtime/host/sandbox/sandbox.go 67.03% <0.00%> (-12.46%) ⬇️
go/runtime/host/protocol/connection.go 62.16% <0.00%> (-7.73%) ⬇️
go/consensus/tendermint/abci/state/state.go 61.53% <0.00%> (-7.70%) ⬇️
go/consensus/tendermint/full/services.go 77.69% <0.00%> (-7.70%) ⬇️
go/oasis-node/cmd/ias/auth.go 68.96% <0.00%> (-6.90%) ⬇️
go/common/sgx/aesm/aesm.go 63.63% <0.00%> (-6.37%) ⬇️
...nsensus/tendermint/apps/beacon/state/state_pvss.go 75.00% <0.00%> (-6.25%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f5a3c6...0354f88. Read the comment docs.

@kostko kostko merged commit 6df3e80 into master Sep 29, 2021
@kostko kostko deleted the kostko/fix/tls-server-refresh branch September 29, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants