Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/common/grpc: Configure max message size on the client #4268

Merged
merged 1 commit into from
Sep 18, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Sep 17, 2021

No description provided.

@kostko kostko force-pushed the kostko/fix/grpc-limits-cli branch from 7cee3ef to bbd6709 Compare September 18, 2021 03:09
@kostko kostko changed the title go/common/grpc: Configure max message size on the client, reduce max go/common/grpc: Configure max message size on the client Sep 18, 2021
@nhynes
Copy link
Contributor

nhynes commented Sep 18, 2021

where did the 100 -> 10 MiB change go?

@codecov
Copy link

codecov bot commented Sep 18, 2021

Codecov Report

Merging #4268 (bbd6709) into master (afcda58) will decrease coverage by 0.53%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4268      +/-   ##
==========================================
- Coverage   69.22%   68.68%   -0.54%     
==========================================
  Files         410      410              
  Lines       47126    47130       +4     
==========================================
- Hits        32622    32372     -250     
- Misses      10492    10734     +242     
- Partials     4012     4024      +12     
Impacted Files Coverage Δ
go/common/grpc/grpc.go 81.36% <100.00%> (-2.18%) ⬇️
go/ias/http/http.go 20.33% <0.00%> (-44.07%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/keymanager/api/policy_sgx.go 33.33% <0.00%> (-13.34%) ⬇️
go/runtime/host/sandbox/sandbox.go 71.06% <0.00%> (-12.09%) ⬇️
go/common/cbor/codec.go 78.37% <0.00%> (-10.82%) ⬇️
go/keymanager/client/client.go 72.72% <0.00%> (-8.27%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
go/oasis-node/cmd/ias/auth.go 68.96% <0.00%> (-6.90%) ⬇️
go/common/sgx/aesm/aesm.go 63.63% <0.00%> (-6.37%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afcda58...bbd6709. Read the comment docs.

@kostko
Copy link
Member Author

kostko commented Sep 18, 2021

where did the 100 -> 10 MiB change go?

Let's consider that separately.

@kostko kostko marked this pull request as ready for review September 18, 2021 04:26
@kostko kostko merged commit 1deb64e into master Sep 18, 2021
@kostko kostko deleted the kostko/fix/grpc-limits-cli branch September 18, 2021 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants