Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh pending upgrades after consensus initialization #4237

Closed
kostko opened this issue Sep 1, 2021 · 0 comments · Fixed by #4238
Closed

Refresh pending upgrades after consensus initialization #4237

kostko opened this issue Sep 1, 2021 · 0 comments · Fixed by #4238
Assignees
@kostko
Labels
c:upgrade Category: upgrade infrastructure

Comments

@kostko
Copy link
Member

kostko commented Sep 1, 2021

Currently we only refresh pending upgrades after performing a state sync. To make this more robust we should always refresh pending upgrades after consensus initialization. This guards against users clearing persistent store and accidentally cancelling upgrades (note that #4071 already prevents this from causing a state corruption).
@kostko kostko added the c:upgrade Category: upgrade infrastructure label Sep 1, 2021
@kostko kostko self-assigned this Sep 1, 2021
@kostko kostko mentioned this issue Sep 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kostko kostko

Labels
c:upgrade Category: upgrade infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

go/consensus/tendermint: Request state refresh on consensus init oasisprotocol/oasis-core
1 participant
@kostko