Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CheckTxBatch and Query don't set MaxMessages #4231

Closed
kostko opened this issue Aug 30, 2021 · 0 comments · Fixed by #4233
Closed

CheckTxBatch and Query don't set MaxMessages #4231

kostko opened this issue Aug 30, 2021 · 0 comments · Fixed by #4233
Assignees
@kostko
Labels
c:breaking/runtime Category: breaking runtime changes c:bug Category: bug c:client Category: client interface c:runtime/compute Category: runtime compute worker c:runtime Category: runtime

Comments

@kostko
Copy link
Member

kostko commented Aug 30, 2021

It seems that CheckTxBatch and Query runtime method invocations don't configure MaxMessages (the field is not even there) which make operations depending on its correct value to not work correctly. This should be changed to populate the value correctly.
@kostko kostko added c:runtime/compute Category: runtime compute worker c:client Category: client interface c:runtime Category: runtime c:bug Category: bug labels Aug 30, 2021
@kostko kostko added the c:breaking/runtime Category: breaking runtime changes label Aug 30, 2021
@kostko kostko self-assigned this Aug 30, 2021
@kostko kostko mentioned this issue Aug 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kostko kostko

Labels
c:breaking/runtime Category: breaking runtime changes c:bug Category: bug c:client Category: client interface c:runtime/compute Category: runtime compute worker c:runtime Category: runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

runtime: Add MaxMessages to CheckTxBatch and Query oasisprotocol/oasis-core
1 participant
@kostko