Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime SubmitTx should fail for unsupported runtimes #4202

Closed
kostko opened this issue Aug 16, 2021 · 0 comments · Fixed by #4204
Closed

Runtime SubmitTx should fail for unsupported runtimes #4202

kostko opened this issue Aug 16, 2021 · 0 comments · Fixed by #4204
Assignees
@kostko
Labels
c:client Category: client interface c:runtime Category: runtime

Comments

@kostko
Copy link
Member

kostko commented Aug 16, 2021

Currently the SubmitTx family of methods will work even when specifying runtimes which are not configured as supported by the node. This will result in the transaction being submitted via the P2P network, but the client will be unable to see any results so the blocking variants will just block forever (or until a timeout).

The correct thing to do would be to fail SubmitTx early.
@kostko kostko added c:client Category: client interface c:runtime Category: runtime labels Aug 16, 2021
@kostko kostko self-assigned this Aug 16, 2021
@kostko kostko mentioned this issue Aug 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kostko kostko

Labels
c:client Category: client interface c:runtime Category: runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

go/runtime/client: Fail SubmitTx early for unsupported runtimes oasisprotocol/oasis-core
1 participant
@kostko