Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup rust code linting #4170

Closed
ptrus opened this issue Aug 4, 2021 · 1 comment · Fixed by #4455
Closed

Setup rust code linting #4170

ptrus opened this issue Aug 4, 2021 · 1 comment · Fixed by #4455
Assignees
@ptrus
Labels
c:ops Category: operations

Comments

@ptrus
Copy link
Member

ptrus commented Aug 4, 2021 •
edited
Loading

Setup clippy in CI to lint rust code.

Will probably require code fixes since the rust code currently won't pass all of the lints. To avoid some unnecessary work should do this only after:
@ptrus ptrus added the c:ops Category: operations label Aug 4, 2021
@ptrus ptrus mentioned this issue Aug 4, 2021
Merged
2 tasks
@Yawning
Copy link
Contributor

Yawning commented Aug 4, 2021

We can also think about integrating more static analysis into our Rust (eg: https://github.com/rust-lang/miri).

@ptrus ptrus self-assigned this Jan 28, 2022
@ptrus ptrus mentioned this issue Jan 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptrus ptrus

Labels
c:ops Category: operations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rust: setup clippy lints and fix existing lint issues oasisprotocol/oasis-core
2 participants
@Yawning @ptrus