You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The fix for golang/go#33772, i.e. to no longer require to run go build with -ldflags=-buildid= set, has been backported to Go 1.13 (golang/go#34326) and is included in the Go 1.13.4 release.
However, when building the oasis-node binary in Oasis Core using GoReleaser via GitHub Actions returns different results depending on the path where the Oasis Core git repository is checked out, unless -buildid= is added to ldflags.
On the other hand, building the oasis-node binary directly via Make's go build invocation works regardless of the path where the Oasis Core git repository is checked out (and without needing -buildid= added to ldflags).
NOTE: Originally reported on Jan 23, 2020 in https://github.com/oasislabs/goreleaser/issues/1.
The fix for golang/go#33772, i.e. to no longer require to run
go build
with-ldflags=-buildid=
set, has been backported to Go 1.13 (golang/go#34326) and is included in the Go 1.13.4 release.However, when building the
oasis-node
binary in Oasis Core using GoReleaser via GitHub Actions returns different results depending on the path where the Oasis Core git repository is checked out, unless-buildid=
is added toldflags
.On the other hand, building the
oasis-node
binary directly via Make'sgo build
invocation works regardless of the path where the Oasis Core git repository is checked out (and without needing-buildid=
added toldflags
).Here is an example GitHub Actions workflow run that demonstrates this issue:
The GoReleaser binaries built from different git paths only differ in:
.note.go.buildid
.note.gnu.build-id
as was discovered in #2571 (comment).
The text was updated successfully, but these errors were encountered: