Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/compute: Replicate input batch locally #4107

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Jul 2, 2021

No description provided.

@kostko kostko added c:runtime/compute Category: runtime compute worker c:storage Category: storage c:bug Category: bug labels Jul 2, 2021
@kostko kostko force-pushed the kostko/fix/executor-local-batch branch from d51699d to 036fbf6 Compare July 2, 2021 10:23
Previously storage commit could fail in case the node was both an executor and
a storage node but not in the storage committee.
@kostko kostko force-pushed the kostko/fix/executor-local-batch branch from 036fbf6 to 0dccf54 Compare July 2, 2021 10:43
@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #4107 (0dccf54) into master (0036da8) will decrease coverage by 0.50%.
The diff coverage is 19.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4107      +/-   ##
==========================================
- Coverage   66.78%   66.28%   -0.51%     
==========================================
  Files         391      410      +19     
  Lines       38138    42380    +4242     
==========================================
+ Hits        25472    28092    +2620     
- Misses       9017    10294    +1277     
- Partials     3649     3994     +345     
Impacted Files Coverage Δ
go/beacon/api/api.go 38.88% <ø> (ø)
go/common/crypto/mrae/api/api.go 20.00% <ø> (ø)
go/common/badger/migrate.go 4.00% <4.00%> (ø)
go/common/badger/helpers.go 34.61% <11.42%> (-47.74%) ⬇️
go/beacon/api/grpc.go 17.31% <17.31%> (ø)
go/common/crypto/pvss/s11n.go 45.08% <75.00%> (+3.87%) ⬆️
go/beacon/api/pvss.go 80.95% <100.00%> (+5.95%) ⬆️
go/beacon/tests/tester.go 86.44% <100.00%> (+0.47%) ⬆️
go/common/accessctl/accessctl.go 81.81% <100.00%> (+2.87%) ⬆️
go/common/backoff/backoff.go 100.00% <100.00%> (ø)
... and 239 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5da7eb8...0dccf54. Read the comment docs.

@kostko kostko merged commit e85fcca into master Jul 2, 2021
@kostko kostko deleted the kostko/fix/executor-local-batch branch July 2, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:runtime/compute Category: runtime compute worker c:storage Category: storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants