-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/worker/storage: Force checkpoint sync when block info unavailable #4080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/fix/storage-cons-state-sync-cp
branch
from
June 24, 2021 19:03
b73c51e
to
d7d22d2
Compare
Codecov Report
@@ Coverage Diff @@
## master #4080 +/- ##
==========================================
- Coverage 66.78% 66.43% -0.36%
==========================================
Files 391 411 +20
Lines 38138 42313 +4175
==========================================
+ Hits 25472 28110 +2638
- Misses 9017 10227 +1210
- Partials 3649 3976 +327
Continue to review full report at Codecov.
|
kostko
force-pushed
the
kostko/fix/storage-cons-state-sync-cp
branch
from
June 25, 2021 11:35
d02ad96
to
9b9e56b
Compare
kostko
requested review from
peterjgilbert,
pro-wh,
ptrus and
Yawning
as code owners
June 25, 2021 11:36
kostko
force-pushed
the
kostko/fix/storage-cons-state-sync-cp
branch
from
June 25, 2021 11:47
8d69e84
to
02c33dd
Compare
Previously if the node used consensus state sync it would fail to receive any updates for the various descriptors until the descriptors were updated after the state sync checkpoint.
kostko
force-pushed
the
kostko/fix/storage-cons-state-sync-cp
branch
from
June 25, 2021 12:04
02c33dd
to
742d63b
Compare
kostko
force-pushed
the
kostko/fix/storage-cons-state-sync-cp
branch
from
June 25, 2021 12:07
742d63b
to
384d90f
Compare
ptrus
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.