Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/common: Move committee storage to Group #4061

Merged
merged 2 commits into from
Jun 22, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 22, 2021

Move committee storage to Group to make it available to all subworkers (instead of the executor worker having a specialized case) and change it so that it doesn't go through gRPC when communicating with the local node.

@kostko kostko requested review from ptrus and jberci June 22, 2021 08:07
@kostko kostko force-pushed the kostko/feature/self-storage-apply branch from 767a5aa to 396e8c2 Compare June 22, 2021 08:12
@kostko kostko force-pushed the kostko/feature/self-storage-apply branch from 396e8c2 to 113ebfc Compare June 22, 2021 08:29
@kostko kostko marked this pull request as ready for review June 22, 2021 08:29
@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #4061 (968eeb0) into master (30a66c9) will decrease coverage by 0.89%.
The diff coverage is 79.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4061      +/-   ##
==========================================
- Coverage   67.30%   66.41%   -0.90%     
==========================================
  Files         411      411              
  Lines       42162    42190      +28     
==========================================
- Hits        28379    28022     -357     
- Misses       9828    10190     +362     
- Partials     3955     3978      +23     
Impacted Files Coverage Δ
go/oasis-node/cmd/node/node.go 54.56% <0.00%> (-1.73%) ⬇️
go/worker/common/committee/node.go 74.03% <0.00%> (-0.72%) ⬇️
go/runtime/registry/registry.go 76.77% <50.00%> (+0.09%) ⬆️
go/storage/client/client.go 75.00% <81.25%> (-1.55%) ⬇️
go/worker/common/committee/group.go 80.60% <85.71%> (+0.88%) ⬆️
go/storage/client/init.go 75.60% <100.00%> (+0.60%) ⬆️
go/worker/compute/executor/committee/node.go 68.11% <100.00%> (-1.29%) ⬇️
go/oasis-node/cmd/ias/auth_registry.go 0.00% <0.00%> (-67.13%) ⬇️
...nsensus/tendermint/apps/keymanager/transactions.go 0.00% <0.00%> (-52.95%) ⬇️
go/ias/http/http.go 18.51% <0.00%> (-44.45%) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30a66c9...968eeb0. Read the comment docs.

@kostko kostko force-pushed the kostko/feature/self-storage-apply branch from 113ebfc to 968eeb0 Compare June 22, 2021 11:03
@kostko kostko merged commit ef23374 into master Jun 22, 2021
@kostko kostko deleted the kostko/feature/self-storage-apply branch June 22, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants