Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Try in vain to improve CI times #4038

Merged
merged 7 commits into from
Jun 30, 2021

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Jun 16, 2021

  • I think using the insecure beacon should be faster in theory, try it
    • Seems faster, between 3 to 63 seconds in execution reduction, time to set the option on even more tests.
  • Remove/rewrite the rust based runtime tests.

@Yawning Yawning force-pushed the yawning/tests/go-faster-plz-omg-wtf branch 2 times, most recently from d8c83e6 to 9bbad1d Compare June 16, 2021 14:55
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #4038 (72f5c14) into master (0036da8) will decrease coverage by 0.35%.
The diff coverage is 31.45%.

❗ Current head 72f5c14 differs from pull request most recent head 234e1fe. Consider uploading reports for the commit 234e1fe to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4038      +/-   ##
==========================================
- Coverage   66.78%   66.43%   -0.36%     
==========================================
  Files         391      411      +20     
  Lines       38138    42317    +4179     
==========================================
+ Hits        25472    28115    +2643     
- Misses       9017    10232    +1215     
- Partials     3649     3970     +321     
Impacted Files Coverage Δ
go/beacon/api/api.go 38.88% <ø> (ø)
go/common/crypto/mrae/api/api.go 20.00% <ø> (ø)
go/common/badger/migrate.go 4.00% <4.00%> (ø)
go/common/badger/helpers.go 34.61% <11.42%> (-47.74%) ⬇️
go/beacon/api/grpc.go 17.31% <17.31%> (ø)
go/common/crypto/sakg/sakg.go 71.42% <71.42%> (ø)
go/common/crypto/pvss/s11n.go 45.08% <75.00%> (+3.87%) ⬆️
go/common/crypto/sakg/bip32.go 95.74% <95.74%> (ø)
go/beacon/api/pvss.go 80.95% <100.00%> (+5.95%) ⬆️
go/beacon/tests/tester.go 86.44% <100.00%> (+0.47%) ⬆️
... and 243 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9fbf29...234e1fe. Read the comment docs.

@Yawning Yawning force-pushed the yawning/tests/go-faster-plz-omg-wtf branch 15 times, most recently from 2456db8 to f788ae9 Compare June 24, 2021 10:48
@Yawning Yawning marked this pull request as ready for review June 24, 2021 11:07
@Yawning Yawning force-pushed the yawning/tests/go-faster-plz-omg-wtf branch 2 times, most recently from 41eaccd to 30a5987 Compare June 24, 2021 11:29
@Yawning Yawning force-pushed the yawning/tests/go-faster-plz-omg-wtf branch 3 times, most recently from 567f0ea to 3760d80 Compare June 24, 2021 11:55
@Yawning Yawning mentioned this pull request Jun 24, 2021
8 tasks
@Yawning Yawning force-pushed the yawning/tests/go-faster-plz-omg-wtf branch 9 times, most recently from 7c3f2fa to ed4dae8 Compare June 29, 2021 10:55
@Yawning Yawning added the s:blocked Status: blocked on other work label Jun 29, 2021
@Yawning
Copy link
Contributor Author

Yawning commented Jun 29, 2021

This requires #4096, because this PR is the one that found the issue.

@Yawning Yawning force-pushed the yawning/tests/go-faster-plz-omg-wtf branch 3 times, most recently from 1bdffcb to 4031355 Compare June 29, 2021 13:00
@Yawning Yawning removed the s:blocked Status: blocked on other work label Jun 29, 2021
@Yawning Yawning force-pushed the yawning/tests/go-faster-plz-omg-wtf branch 3 times, most recently from 27208f0 to fb86bbc Compare June 29, 2021 14:36
@Yawning Yawning force-pushed the yawning/tests/go-faster-plz-omg-wtf branch from fb86bbc to 234e1fe Compare June 30, 2021 08:27
@Yawning Yawning merged commit 1cc97b1 into master Jun 30, 2021
@Yawning Yawning deleted the yawning/tests/go-faster-plz-omg-wtf branch June 30, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants