Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable development on macOS without docker #4024

Merged
merged 4 commits into from
Jun 15, 2021
Merged

Enable development on macOS without docker #4024

merged 4 commits into from
Jun 15, 2021

Conversation

nhynes
Copy link
Contributor

@nhynes nhynes commented Jun 12, 2021

This PR:

  • adds conditional compilation to the oasis-core-runtime-loader
  • allows setting the provisioner through oasis-net-runner (to unconfined)
  • allows running a net without a keymanager since simple-keymanager isn't fun to compile with musl

go/oasis-net-runner/fixtures/default.go Outdated Show resolved Hide resolved
go/oasis-test-runner/oasis/network.go Outdated Show resolved Hide resolved
@nhynes nhynes force-pushed the nhynes/macos-dev branch from ef7c456 to 5eff0c8 Compare June 14, 2021 14:28
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #4024 (5eff0c8) into master (bbc6e9d) will increase coverage by 0.18%.
The diff coverage is n/a.

❗ Current head 5eff0c8 differs from pull request most recent head a082cd3. Consider uploading reports for the commit a082cd3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4024      +/-   ##
==========================================
+ Coverage   66.96%   67.15%   +0.18%     
==========================================
  Files         410      410              
  Lines       42183    42183              
==========================================
+ Hits        28249    28329      +80     
+ Misses       9938     9878      -60     
+ Partials     3996     3976      -20     
Impacted Files Coverage Δ
go/common/sgx/common.go 58.53% <0.00%> (-4.88%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 66.19% <0.00%> (-3.34%) ⬇️
go/worker/storage/service_external.go 54.28% <0.00%> (-2.86%) ⬇️
go/runtime/nodes/grpc/grpc.go 71.93% <0.00%> (-1.98%) ⬇️
.../consensus/tendermint/apps/roothash/state/state.go 68.64% <0.00%> (-1.70%) ⬇️
go/oasis-node/cmd/stake/delegations.go 79.24% <0.00%> (-0.95%) ⬇️
go/consensus/tendermint/full/services.go 80.00% <0.00%> (ø)
go/consensus/tendermint/roothash/roothash.go 67.40% <0.00%> (ø)
...o/consensus/tendermint/apps/beacon/backend_pvss.go 60.00% <0.00%> (+0.43%) ⬆️
go/worker/common/p2p/peermgmt.go 81.50% <0.00%> (+0.57%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbc6e9d...a082cd3. Read the comment docs.

@nhynes nhynes force-pushed the nhynes/macos-dev branch from 5eff0c8 to c277c04 Compare June 14, 2021 18:14
@nhynes nhynes force-pushed the nhynes/macos-dev branch from c277c04 to 2fd0289 Compare June 14, 2021 18:50
@nhynes nhynes force-pushed the nhynes/macos-dev branch from 2fd0289 to 309fd6b Compare June 14, 2021 19:16
@nhynes nhynes force-pushed the nhynes/macos-dev branch from 309fd6b to 5eed22d Compare June 14, 2021 19:45
@nhynes nhynes enabled auto-merge June 14, 2021 20:11
@nhynes nhynes force-pushed the nhynes/macos-dev branch from 5bc076a to a082cd3 Compare June 15, 2021 13:42
@nhynes nhynes merged commit d14e205 into master Jun 15, 2021
@nhynes nhynes deleted the nhynes/macos-dev branch June 15, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants