Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: The runtime tests should build even without OASIS_STORAGE_PROTOCOL_SERVER_BINARY #4023

Closed
Yawning opened this issue Jun 11, 2021 · 0 comments · Fixed by #4027
Closed

tests: The runtime tests should build even without OASIS_STORAGE_PROTOCOL_SERVER_BINARY #4023

Yawning opened this issue Jun 11, 2021 · 0 comments · Fixed by #4027
Labels
c:runtime Category: runtime c:testing Category: testing s:good first issue Status: good for newcomers

Comments

@Yawning
Copy link
Contributor

Yawning commented Jun 11, 2021

When working on unrelated parts of the rust runtime, it would be nice if cargo test will compile even if OASIS_STORAGE_PROTOCOL_SERVER_BINARY isn't set (the tests that require it should just fail).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c:runtime Category: runtime c:testing Category: testing s:good first issue Status: good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

runtime: Do not require OASIS_STORAGE_PROTOCOL_SERVER_BINARY oasisprotocol/oasis-core
1 participant
@Yawning