Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/staking: Add DebondingStartEscrowEvent #4014

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 10, 2021

This makes it easier to reason about the debonded amounts, both in shares and
in base units.

@kostko kostko requested review from tjanez and ptrus June 10, 2021 07:18
@kostko kostko force-pushed the kostko/feature/staking-evt-debstart branch 2 times, most recently from aac1702 to f31bc77 Compare June 10, 2021 07:40
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #4014 (f31bc77) into master (5248989) will decrease coverage by 0.06%.
The diff coverage is 77.77%.

❗ Current head f31bc77 differs from pull request most recent head 2c2a01b. Consider uploading reports for the commit 2c2a01b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4014      +/-   ##
==========================================
- Coverage   67.02%   66.96%   -0.07%     
==========================================
  Files         412      412              
  Lines       42263    42298      +35     
==========================================
- Hits        28328    28325       -3     
- Misses       9945     9972      +27     
- Partials     3990     4001      +11     
Impacted Files Coverage Δ
go/staking/api/api.go 58.87% <ø> (ø)
go/consensus/tendermint/staking/staking.go 55.72% <57.14%> (+0.05%) ⬆️
go/staking/tests/tester.go 91.49% <80.00%> (-0.33%) ⬇️
.../consensus/tendermint/apps/staking/transactions.go 68.54% <88.88%> (+0.69%) ⬆️
...nsensus/tendermint/apps/beacon/state/state_pvss.go 69.23% <0.00%> (-7.70%) ⬇️
go/consensus/tendermint/apps/beacon/genesis.go 62.50% <0.00%> (-6.25%) ⬇️
go/worker/keymanager/handler.go 69.38% <0.00%> (-6.13%) ⬇️
...nsensus/tendermint/apps/staking/signing_rewards.go 20.00% <0.00%> (-5.72%) ⬇️
go/runtime/nodes/grpc/grpc.go 71.93% <0.00%> (-3.56%) ⬇️
go/keymanager/client/client.go 76.31% <0.00%> (-3.51%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5248989...2c2a01b. Read the comment docs.

@kostko kostko marked this pull request as ready for review June 10, 2021 10:03
@kostko kostko force-pushed the kostko/feature/staking-evt-debstart branch from f31bc77 to 927d4f2 Compare June 10, 2021 10:09
@kostko kostko force-pushed the kostko/feature/staking-evt-debstart branch 2 times, most recently from 08e62d7 to 3110dcc Compare June 10, 2021 10:35
@kostko kostko changed the title go/staking: Add DebondingStartEvent go/staking: Add DebondingStartEscrowEvent Jun 10, 2021
go/consensus/tendermint/apps/staking/api.go Outdated Show resolved Hide resolved
go/consensus/tendermint/staking/staking.go Outdated Show resolved Hide resolved
go/consensus/tendermint/staking/staking.go Outdated Show resolved Hide resolved
This makes it easier to reason about the debonded amounts, both in shares and
in base units.
@kostko kostko force-pushed the kostko/feature/staking-evt-debstart branch from 3110dcc to 2c2a01b Compare June 10, 2021 11:34
Copy link
Contributor

@Yawning Yawning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

@kostko kostko enabled auto-merge June 10, 2021 11:48
@kostko kostko merged commit 2e7cfdc into master Jun 10, 2021
@kostko kostko deleted the kostko/feature/staking-evt-debstart branch June 10, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants