workload/governance: fix case with multiple identical active proposals #3959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
ptrus
force-pushed
the
ptrus/fix/workload-governance
branch
2 times, most recently
from
9c4ebe4 to
265aac1
Compare
ptrus
changed the title
kostko
approved these changes
May 21, 2021
.changelog/3959.bugfix.md
Outdated
| @@ -0,0 +1 @@ | |||
| workload/governance: fix case with multiple equal active proposals | |||
There was a problem hiding this comment.
Maybe mark this as internal as the issue is in E2E tests.
There was a problem hiding this comment.
Agreed, was thinking the same, just wasn't sure what the usual convention for these cases 👍
ptrus
force-pushed
the
ptrus/fix/workload-governance
branch
from
265aac1 to
b466738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found in daily longerm test (thanks @kostko)