Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staking event updates/improvements #3939

Closed
ptrus opened this issue May 12, 2021 · 0 comments · Fixed by #3944
Closed

Staking event updates/improvements #3939

ptrus opened this issue May 12, 2021 · 0 comments · Fixed by #3944
Assignees
Labels
c:breaking Category: breaking code change

Comments

@ptrus
Copy link
Member

ptrus commented May 12, 2021

AddEscrowEvent: include amount of shares that the were obtained in the event
ReclaimEscrowEvent: include amount of shares that were reclaimed in the event

Currently on escrow, one cannot know the amount of shares the escrow resulted in without querying the staking state (before and after the operation), or by manually calculating the share price at the exact height of the escrow. Adding the amount of shares to the AddEscrowEvent solves this.

Similarly for ReclaimEscrowEvent to know the amount of shares that were reclaimed one would need to query DebondingDelegations before the emitted event and match the reclaimed amount/epoch with the delegation.

In both cases we have the amount of share information available when we emit these events, it is just not included in the events.

Note: changing events is a breaking (but currently not a consensus-breaking) change.

@ptrus ptrus added the c:breaking Category: breaking code change label May 12, 2021
@ptrus ptrus self-assigned this May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:breaking Category: breaking code change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant