ADR 0008: Standard Account Key Generation implementation #3918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjanez
added
c:apps
tjanez
force-pushed
the
tjanez/adr-0008-implementation
branch
from
0da0e00 to
a32a46c
Compare
tjanez
changed the title
tjanez
force-pushed
the
tjanez/adr-0008-implementation
branch
from
a32a46c to
dd28f18
Compare
tjanez
force-pushed
the
tjanez/adr-0008-implementation
branch
from
dd28f18 to
3eeb698
Compare
tjanez
force-pushed
the
tjanez/adr-0008-implementation
branch
from
3eeb698 to
3243f71
Compare
tjanez
requested review from
kostko,
peterjgilbert,
pro-wh,
ptrus and
Yawning
as code owners
tjanez
force-pushed
the
tjanez/adr-0008-implementation
branch
from
3243f71 to
2c15fc9
Compare
Yawning
reviewed
May 10, 2021
| ## Standard Account Key Generation | ||
|
|
||
| When generating an [account]'s private/public key pair, follow [ADR 0008: | ||
| Standard Account Key Generation][ADR 0008]. |
There was a problem hiding this comment.
How do we intend to handle "nothing up until this point (strictly speaking even after this point), used this method"?
Does it not matter? Migration tools? Should the oasis-core tooling be updated to use this stuff?
There was a problem hiding this comment.
Upcoming wallets using ts-web JavaScript SDK will be the first users of this: oasisprotocol/oasis-sdk#119.
We should extend the Oasis Node CLI to support generating an account key (i.e. entity) from a mnemonic.
Upcoming TrustWallet integration will use ADR 0008.
The Oasis' Ledger app will need to support both the existing (legacy) account key generation used now and the new standard account key generation defined in ADR 0008.
tjanez
force-pushed
the
tjanez/adr-0008-implementation
branch
2 times, most recently
from
4c6ef43 to
330b82b
Compare
Yawning
reviewed
May 12, 2021
tjanez
force-pushed
the
tjanez/adr-0008-implementation
branch
2 times, most recently
from
c68dd86 to
3df0ae2
Compare
tjanez
force-pushed
the
tjanez/adr-0008-implementation
branch
from
3df0ae2 to
88fb230
Compare
Yawning
approved these changes
May 19, 2021
tjanez
force-pushed
the
tjanez/adr-0008-implementation
branch
from
88fb230 to
ce2a227
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of ADR 0008.