runtime: Support for block tags #3848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/feature/runtime-block-tags
branch
from
c91c105 to
7a37900
Compare
kostko
reviewed
Apr 12, 2021
Codecov Report
@@ Coverage Diff @@
## master #3848 +/- ##
==========================================
+ Coverage 66.99% 67.06% +0.07%
==========================================
Files 404 404
Lines 41467 41467
==========================================
+ Hits 27779 27811 +32
+ Misses 9740 9708 -32
Partials 3948 3948
Continue to review full report at Codecov.
|
6 tasks
ptrus
force-pushed
the
ptrus/feature/runtime-block-tags
branch
2 times, most recently
from
c54f9e1 to
08d749b
Compare
ptrus
force-pushed
the
ptrus/feature/runtime-block-tags
branch
from
08d749b to
30c014d
Compare
kostko
approved these changes
Apr 19, 2021
| @@ -0,0 +1 @@ | |||
| runtime: Add support for block tags | |||
There was a problem hiding this comment.
Hm i was thinking to mark it as breaking as ExecuteTxResult (publicly exposed runtime api struct) was changed. I guess it depends on what definition of "breaking" we'd like to use for these fragments :-)
There was a problem hiding this comment.
Oh, yeah that's true, keep it as breaking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime: Add support for block tags (tags not emitted by a specific transaction).
Needed for: oasis-sdk#consensus-module (oasisprotocol/oasis-sdk#92)