Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: Add pretty-printers for governance and upgrade types #3800

Merged
merged 3 commits into from
Mar 18, 2021
Merged

go: Add pretty-printers for governance and upgrade types #3800

merged 3 commits into from
Mar 18, 2021

Conversation

tjanez
Copy link
Member

@tjanez tjanez commented Mar 18, 2021

Examples of various transaction pretty-prints:

Method: governance.SubmitProposal
Body:
  Upgrade:
    Handler: upgrade1
    Target Version:
      Consensus Protocol: 3.0.0
      Runtime Host Protocol: 2.0.0
      Runtime Committee Protocol: 2.0.0
    Epoch: 3828
Nonce:  0
Fee:
  Amount: 0.00003 ROSE
  Gas limit: 2000
  (gas price: 0.000000015 ROSE per gas unit)

Method: governance.SubmitProposal
Body:
  Cancel Upgrade:
    Proposal ID: 15
Nonce:  0
Fee:
  Amount: 0.00003 ROSE
  Gas limit: 2000
  (gas price: 0.000000015 ROSE per gas unit)

Method: governance.CastVote
Body:
  Proposal ID: 12
  Vote:        yes
Nonce:  0
Fee:
  Amount: 0.00003 ROSE
  Gas limit: 2000
  (gas price: 0.000000015 ROSE per gas unit)

tjanez added 2 commits March 18, 2021 13:21
@tjanez
go/governance: Implement PrettyPrint interface for various types
483f1ca 
Implement PrettyPrint for ProposalContent, UpgradeProposal,
CancelUpgradeProposal and ProposalVote types.
@tjanez
go/upgrade: Implement PrettyPrint interface for Descriptor
67b1c51
@tjanez tjanez force-pushed the tjanez/pprinters branch from d5012d5 to 67b1c51 Compare March 18, 2021 12:23
@tjanez tjanez enabled auto-merge March 18, 2021 12:24
@tjanez tjanez merged commit 1e16eed into master Mar 18, 2021
@tjanez tjanez deleted the tjanez/pprinters branch March 18, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@ptrus ptrus Awaiting requested review from ptrus ptrus is a code owner

@Yawning Yawning Awaiting requested review from Yawning

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjanez @kostko