Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/oasis-node/cmd: Improve transaction preview when generating txns #3792

Merged
merged 2 commits into from
Mar 17, 2021

Conversation

tjanez
Copy link
Member

@tjanez tjanez commented Mar 17, 2021

Display amounts in tokens and display genesis document's hash when previewing transactions with various oasis-node * gen_* CLI commands.

@tjanez tjanez added the c:cli Category: command line interface label Mar 17, 2021
@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #3792 (46ac732) into master (3a80506) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

❗ Current head 46ac732 differs from pull request most recent head a91700d. Consider uploading reports for the commit a91700d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3792      +/-   ##
==========================================
- Coverage   67.27%   67.26%   -0.02%     
==========================================
  Files         403      404       +1     
  Lines       40882    40882              
==========================================
- Hits        27505    27498       -7     
- Misses       9499     9504       +5     
- Partials     3878     3880       +2     
Impacted Files Coverage Δ
go/oasis-node/cmd/governance/governance.go 22.00% <0.00%> (ø)
go/oasis-node/cmd/common/context/context.go 100.00% <100.00%> (ø)
go/oasis-node/cmd/keymanager/keymanager.go 47.59% <100.00%> (ø)
go/oasis-node/cmd/registry/entity/entity.go 42.27% <100.00%> (ø)
go/oasis-node/cmd/registry/runtime/runtime.go 61.71% <100.00%> (ø)
go/oasis-node/cmd/stake/account.go 58.33% <100.00%> (-0.69%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.38% <0.00%> (-19.24%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 78.94% <0.00%> (-10.53%) ⬇️
go/worker/common/committee/runtime_host.go 64.28% <0.00%> (-6.25%) ⬇️
go/consensus/tendermint/apps/beacon/genesis.go 62.50% <0.00%> (-6.25%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a80506...a91700d. Read the comment docs.

@tjanez tjanez force-pushed the tjanez/cmd-context-with-genesis-info branch from 69d645a to 46ac732 Compare March 17, 2021 15:43
@tjanez tjanez enabled auto-merge March 17, 2021 15:43
tjanez added 2 commits March 17, 2021 19:18
Move existing getCtxWithInfo() from go/oasis-node/cmd/stake to a common
place and make it public so it can be used by all go/oasis-node/cmd
sub-commands.
Display amounts in tokens and display genesis document's hash when
previewing transactions.
@tjanez tjanez force-pushed the tjanez/cmd-context-with-genesis-info branch from 46ac732 to a91700d Compare March 17, 2021 18:19
@tjanez tjanez merged commit a39d1e1 into master Mar 17, 2021
@tjanez tjanez deleted the tjanez/cmd-context-with-genesis-info branch March 17, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:cli Category: command line interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants