go/consensus: Move upgrade logic to governance, gracefully handle halt #3755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
requested review from
peterjgilbert,
pro-wh,
ptrus and
Yawning
as code owners
ptrus
approved these changes
Mar 4, 2021
kostko
force-pushed
the
kostko/fix/upgrade-halt
branch
7 times, most recently
from
59042fc to
a4c8d42
Compare
ptrus
approved these changes
Mar 5, 2021
| go func() { | ||
| // Sleep another period so there is some time between when consensus shuts down and | ||
| // when all the other services start shutting down. | ||
| time.Sleep(waitPeriod) |
There was a problem hiding this comment.
Would it make more sense to use a different (static, not dependent on TimeoutCommit) period here?
kostko
force-pushed
the
kostko/fix/upgrade-halt
branch
from
a4c8d42 to
8b391b6
Compare
Codecov Report
@@ Coverage Diff @@
## master #3755 +/- ##
==========================================
- Coverage 67.07% 67.02% -0.06%
==========================================
Files 401 401
Lines 39927 39970 +43
==========================================
+ Hits 26783 26790 +7
- Misses 9363 9368 +5
- Partials 3781 3812 +31
Continue to review full report at Codecov.
|
kostko
force-pushed
the
kostko/fix/upgrade-halt
branch
from
8b391b6 to
d1d1ebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.