Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/common/quantity: Add Mul/Div implementations #3744

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Mar 2, 2021

No description provided.

@kostko kostko added the c:runtime Category: runtime label Mar 2, 2021
@kostko kostko force-pushed the kostko/feature/rt-qty-muldiv branch 3 times, most recently from 4469e66 to 2d16e41 Compare March 2, 2021 12:09
@kostko kostko marked this pull request as ready for review March 2, 2021 12:18
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #3744 (2d16e41) into master (a1a7ae6) will decrease coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3744      +/-   ##
==========================================
- Coverage   67.12%   66.81%   -0.31%     
==========================================
  Files         401      401              
  Lines       39898    39898              
==========================================
- Hits        26781    26658     -123     
- Misses       9348     9442      +94     
- Partials     3769     3798      +29     
Impacted Files Coverage Δ
go/runtime/host/sandbox/sandbox.go 69.53% <0.00%> (-10.55%) ⬇️
go/common/sgx/aesm/aesm.go 62.61% <0.00%> (-8.42%) ⬇️
go/consensus/tendermint/apps/beacon/state/state.go 70.49% <0.00%> (-6.56%) ⬇️
go/common/sgx/common.go 58.53% <0.00%> (-4.88%) ⬇️
go/runtime/host/sgx/sgx.go 69.23% <0.00%> (-4.40%) ⬇️
go/consensus/tendermint/apps/beacon/beacon.go 71.73% <0.00%> (-4.35%) ⬇️
go/consensus/tendermint/full/services.go 80.00% <0.00%> (-4.17%) ⬇️
go/consensus/tendermint/roothash/roothash.go 69.03% <0.00%> (-3.81%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 66.19% <0.00%> (-2.39%) ⬇️
go/keymanager/client/client.go 79.82% <0.00%> (-1.76%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1a7ae6...ce779d2. Read the comment docs.

@kostko kostko force-pushed the kostko/feature/rt-qty-muldiv branch from 2d16e41 to b94299c Compare March 2, 2021 12:56
@kostko kostko force-pushed the kostko/feature/rt-qty-muldiv branch from b94299c to ce779d2 Compare March 2, 2021 13:06
@kostko kostko enabled auto-merge March 2, 2021 13:09
@kostko kostko merged commit d186644 into master Mar 2, 2021
@kostko kostko deleted the kostko/feature/rt-qty-muldiv branch March 2, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:runtime Category: runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants