Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure tracing is only enabled in debug mode #3679

Merged
merged 2 commits into from
Feb 5, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Feb 5, 2021

No description provided.

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #3679 (285ece0) into master (789751c) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3679      +/-   ##
==========================================
- Coverage   66.70%   66.68%   -0.02%     
==========================================
  Files         393      393              
  Lines       38367    38370       +3     
==========================================
- Hits        25592    25588       -4     
+ Misses       9102     9098       -4     
- Partials     3673     3684      +11     
Impacted Files Coverage Δ
go/oasis-node/cmd/common/tracing/tracing.go 66.66% <33.33%> (-4.31%) ⬇️
go/worker/common/committee/group.go 74.42% <50.00%> (-1.83%) ⬇️
go/common/grpc/grpc.go 84.89% <100.00%> (-0.29%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.38% <0.00%> (-19.24%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 78.94% <0.00%> (-10.53%) ⬇️
go/common/grpc/policy/policy.go 62.12% <0.00%> (-7.58%) ⬇️
go/consensus/tendermint/full/services.go 80.00% <0.00%> (-4.17%) ⬇️
go/worker/keymanager/worker.go 61.06% <0.00%> (-2.81%) ⬇️
.../consensus/tendermint/apps/roothash/state/state.go 71.25% <0.00%> (-2.50%) ⬇️
go/runtime/host/protocol/connection.go 57.55% <0.00%> (-2.45%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 789751c...285ece0. Read the comment docs.

When long node restarts are enabled (e.g., nodes can be stopped for 10 min) it
can happen that the backup worker is stopped together with one of the primary
workers. Since we only have a single backup this will prevent discrepancy
resolution and cause rounds to always fail.
@kostko kostko force-pushed the kostko/fix/tracing-debug-only branch from 79740e6 to 285ece0 Compare February 5, 2021 11:11
@kostko kostko marked this pull request as ready for review February 5, 2021 11:53
@kostko kostko merged commit fb4d615 into master Feb 5, 2021
@kostko kostko deleted the kostko/fix/tracing-debug-only branch February 5, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants