Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: Add support for runtime queries #3662

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Conversation

kostko
Copy link
Member

@kostko kostko commented Jan 29, 2021

Based on #3653

@kostko kostko force-pushed the kostko/feature/rt-client-side branch from 8509b23 to c17d9e1 Compare February 1, 2021 09:51
@kostko kostko force-pushed the kostko/feature/rt-queries branch from 5f5c216 to 225edb5 Compare February 1, 2021 11:55
@kostko kostko marked this pull request as ready for review February 1, 2021 12:57
@kostko kostko force-pushed the kostko/feature/rt-client-side branch from c17d9e1 to b9a4c6b Compare February 1, 2021 14:02
@kostko kostko force-pushed the kostko/feature/rt-queries branch from 225edb5 to 93e5976 Compare February 1, 2021 14:04
Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might it also make sense to expose CheckTx this way?

runtime/src/dispatcher.rs Show resolved Hide resolved
runtime/src/protocol.rs Show resolved Hide resolved
@kostko kostko force-pushed the kostko/feature/rt-client-side branch 2 times, most recently from 5b174c3 to 80710c8 Compare February 2, 2021 09:52
@kostko
Copy link
Member Author

kostko commented Feb 2, 2021

might it also make sense to expose CheckTx this way?

That's a very good idea.

@kostko kostko force-pushed the kostko/feature/rt-client-side branch from 80710c8 to f386f83 Compare February 3, 2021 12:27
Base automatically changed from kostko/feature/rt-client-side to master February 3, 2021 13:21
@kostko kostko force-pushed the kostko/feature/rt-queries branch from 93e5976 to 592430c Compare February 3, 2021 14:07
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #3662 (592430c) into master (9e37cea) will decrease coverage by 0.03%.
The diff coverage is 65.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3662      +/-   ##
==========================================
- Coverage   66.76%   66.72%   -0.04%     
==========================================
  Files         393      393              
  Lines       38274    38335      +61     
==========================================
+ Hits        25552    25580      +28     
- Misses       9069     9091      +22     
- Partials     3653     3664      +11     
Impacted Files Coverage Δ
go/runtime/host/protocol/types.go 42.85% <ø> (ø)
go/runtime/client/client.go 64.43% <38.46%> (-1.25%) ⬇️
go/runtime/host/helpers.go 55.55% <60.00%> (+3.17%) ⬆️
go/runtime/client/api/grpc.go 61.29% <61.11%> (-0.02%) ⬇️
go/runtime/client/tests/tester.go 100.00% <100.00%> (ø)
go/runtime/host/mock/mock.go 88.73% <100.00%> (+0.85%) ⬆️
go/consensus/tendermint/abci/state/state.go 54.54% <0.00%> (-9.10%) ⬇️
...nsensus/tendermint/apps/beacon/state/state_pvss.go 69.23% <0.00%> (-7.70%) ⬇️
go/worker/common/committee/runtime_host.go 64.28% <0.00%> (-6.25%) ⬇️
go/consensus/api/submission.go 69.01% <0.00%> (-4.23%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e37cea...30110a5. Read the comment docs.

@kostko kostko force-pushed the kostko/feature/rt-queries branch from 592430c to be25fe2 Compare February 3, 2021 17:34
@kostko
Copy link
Member Author

kostko commented Feb 3, 2021

@pro-wh Also exposed CheckTx now.

Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes, lg

@kostko kostko force-pushed the kostko/feature/rt-queries branch from be25fe2 to 30110a5 Compare February 3, 2021 18:44
@kostko kostko enabled auto-merge February 3, 2021 18:45
@kostko kostko merged commit 278c54b into master Feb 3, 2021
@kostko kostko deleted the kostko/feature/rt-queries branch February 3, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants