Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Add support for new runtime entity whitelist admission policy format #3626

Closed
abukosek opened this issue Jan 13, 2021 · 0 comments · Fixed by #3903
Closed

cli: Add support for new runtime entity whitelist admission policy format #3626

abukosek opened this issue Jan 13, 2021 · 0 comments · Fixed by #3903
Assignees
Labels
c:cli Category: command line interface s:good first issue Status: good for newcomers

Comments

@abukosek
Copy link
Contributor

Recent changes for ADR 0004 have modified the runtimes' entity whitelist admission policy structure, so that it's possible to specify the maximum number of nodes that an entity can register under the given runtime for a specific role.

This requires the command-line parsing in go/oasis-node/cmd/registry/runtime/runtime.go to be updated.

In the current implementation, the same syntax as before configures an unlimited number of nodes of any role for the given entry, which matches previous behavior.

Parsing a nested map on the command-line might not be the best way to solve this. Perhaps a configuration file would be more user-friendly.

@abukosek abukosek added s:good first issue Status: good for newcomers c:cli Category: command line interface labels Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:cli Category: command line interface s:good first issue Status: good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants