Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/oasis-node/txsource: Fix event validation in queries workload #3593

Merged
merged 1 commit into from
Jan 3, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Jan 2, 2021

There seems to be a bug in the queries workload event validation which fails in case two same events are emitted -- which seems like a perfectly valid thing that can happen now with a single transaction performing runtime message execution emitting events.

Discovered during long-term tests.

@kostko kostko added the c:testing Category: testing label Jan 2, 2021
@kostko kostko requested a review from ptrus January 2, 2021 21:06
@kostko kostko force-pushed the kostko/fix/e2e-queries-ev-dupes branch from e09aaa5 to 1af4d1b Compare January 2, 2021 21:19
@kostko kostko added the c:bug Category: bug label Jan 2, 2021
@codecov
Copy link

codecov bot commented Jan 2, 2021

Codecov Report

Merging #3593 (1af4d1b) into master (10af4a3) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3593      +/-   ##
==========================================
- Coverage   66.60%   66.58%   -0.02%     
==========================================
  Files         377      377              
  Lines       34562    34562              
==========================================
- Hits        23019    23013       -6     
+ Misses       8228     8227       -1     
- Partials     3315     3322       +7     
Impacted Files Coverage Δ
go/oasis-node/cmd/common/metrics/disk.go 65.38% <0.00%> (-19.24%) ⬇️
go/runtime/host/sandbox/sandbox.go 66.01% <0.00%> (-10.55%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 78.94% <0.00%> (-10.53%) ⬇️
go/keymanager/client/client.go 78.94% <0.00%> (-4.39%) ⬇️
go/consensus/tendermint/full/services.go 81.35% <0.00%> (-4.24%) ⬇️
...n/crypto/signature/signers/memory/memory_signer.go 72.41% <0.00%> (-3.45%) ⬇️
go/runtime/nodes/grpc/grpc.go 71.88% <0.00%> (-2.82%) ⬇️
go/worker/storage/committee/checkpoint_sync.go 73.92% <0.00%> (-2.73%) ⬇️
go/storage/database/database.go 68.23% <0.00%> (-2.36%) ⬇️
...consensus/tendermint/apps/scheduler/state/state.go 65.90% <0.00%> (-2.28%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10af4a3...1af4d1b. Read the comment docs.

@kostko kostko merged commit ce5be5c into master Jan 3, 2021
@kostko kostko deleted the kostko/fix/e2e-queries-ev-dupes branch January 3, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:testing Category: testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants