Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more updates when registering an "expired" node #3539

Closed
ptrus opened this issue Nov 30, 2020 · 1 comment · Fixed by #3733
Closed

Allow more updates when registering an "expired" node #3539

ptrus opened this issue Nov 30, 2020 · 1 comment · Fixed by #3733
Assignees
Labels
c:registry Category: entity/node/runtime registry service

Comments

@ptrus
Copy link
Member

ptrus commented Nov 30, 2020

Registering an expired (but not yet deleted) node is currently subject to the same update restriction rules as an active node being updated. However it would make sense for expired nodes to be allowed to update certain(most?) fields.
AFAIK the reasons for restrictions apply mostly to active nodes - since most restrictions are there to prevent certain mid-epoch updates (e.g. removing node support for a runtime mid-epoch).

For example: currently a node needs to be unregistered for a debonding-period number of epochs, before it is able to register without a previously registered runtime.

@kostko kostko added the c:registry Category: entity/node/runtime registry service label Nov 30, 2020
@kostko
Copy link
Member

kostko commented Nov 30, 2020

However it would make sense for expired nodes to be allowed to update certain(most?) fields.

As long as the consensus key cannot be updated for an expired node that's probably ok.

@kostko kostko changed the title Allow arbitrary updates when registering an "expired" node Allow more updates when registering an "expired" node Dec 1, 2020
@ptrus ptrus self-assigned this Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:registry Category: entity/node/runtime registry service
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants