Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Go OverlayTree implementation to behave like the Rust one #3501

Open
kostko opened this issue Nov 10, 2020 · 0 comments
Open

Change Go OverlayTree implementation to behave like the Rust one #3501

kostko opened this issue Nov 10, 2020 · 0 comments
Labels
c:storage Category: storage

Comments

@kostko
Copy link
Member

kostko commented Nov 10, 2020 •
edited
Loading

#3499 introduces a Rust OverlayTree implementation with some improvements over the Go one. We should make sure to also update the Go implementation with the improvements, specifically:

  • Using an in-memory B-Tree for the overlay (a B-Tree because we need to support iterators). Currently a regular Tree is used which may be suboptimal.
  • (maybe) Removing WriteLog support from the regular Tree and make sure that you need to use the OverlayTree if you want to get a WriteLog.
@kostko kostko added the c:storage Category: storage label Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c:storage Category: storage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kostko