Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/common/crypto: Bump ed25519 version #3471

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Nov 3, 2020

TODO

  • Bump to tagged version of Tendermint Core.

@kostko kostko added the c:breaking/consensus Category: breaking consensus changes label Nov 3, 2020
@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #3471 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3471   +/-   ##
=======================================
  Coverage   66.31%   66.32%           
=======================================
  Files         371      371           
  Lines       33750    33750           
=======================================
+ Hits        22382    22385    +3     
+ Misses       8098     8092    -6     
- Partials     3270     3273    +3     
Impacted Files Coverage Δ
...consensus/tendermint/apps/roothash/transactions.go 50.00% <0.00%> (-4.32%) ⬇️
go/storage/mkvs/remove.go 85.56% <0.00%> (-4.13%) ⬇️
.../consensus/tendermint/apps/roothash/state/state.go 74.28% <0.00%> (-2.86%) ⬇️
go/worker/common/committee/node.go 74.86% <0.00%> (-2.80%) ⬇️
go/storage/database/database.go 68.23% <0.00%> (-2.36%) ⬇️
go/runtime/client/watcher.go 63.70% <0.00%> (-1.49%) ⬇️
go/runtime/committee/client.go 77.06% <0.00%> (-1.38%) ⬇️
go/consensus/tendermint/apps/roothash/roothash.go 73.10% <0.00%> (-0.95%) ⬇️
go/consensus/tendermint/full/full.go 62.43% <0.00%> (-0.54%) ⬇️
go/worker/compute/executor/committee/node.go 66.94% <0.00%> (-0.48%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efce218...b868d4e. Read the comment docs.

@kostko kostko force-pushed the kostko/fix/bump-ed25519-small-r branch from 5f9b847 to b868d4e Compare November 3, 2020 16:52
@kostko kostko marked this pull request as ready for review November 3, 2020 16:52
@kostko kostko merged commit ef3a228 into master Nov 3, 2020
@kostko kostko deleted the kostko/fix/bump-ed25519-small-r branch November 3, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:breaking/consensus Category: breaking consensus changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants