Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go consensus: add last retained block information #3348

Merged
merged 4 commits into from
Oct 1, 2020

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Sep 30, 2020

Copy link
Contributor

@abukosek abukosek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this change also bump the ConsensusProtocol version in go/common/version/version.go?

@kostko
Copy link
Member

kostko commented Oct 1, 2020

Should this change also bump the ConsensusProtocol version in go/common/version/version.go?

Nope, it's not a breaking consensus change, just adding some fields to the status response.

kostko
kostko previously approved these changes Oct 1, 2020
@kostko kostko dismissed their stale review October 1, 2020 07:31

Issue with error handling.

@kostko kostko added c:client Category: client interface c:consensus/cometbft Category: CometBFT labels Oct 1, 2020
@pro-wh pro-wh requested a review from kostko October 1, 2020 18:21
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #3348 into master will increase coverage by 0.14%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3348      +/-   ##
==========================================
+ Coverage   65.32%   65.47%   +0.14%     
==========================================
  Files         371      371              
  Lines       33174    33186      +12     
==========================================
+ Hits        21671    21727      +56     
+ Misses       8284     8264      -20     
+ Partials     3219     3195      -24     
Impacted Files Coverage Δ
go/consensus/api/api.go 14.28% <ø> (ø)
go/consensus/tendermint/full/full.go 61.08% <81.81%> (+0.43%) ⬆️
go/consensus/tests/tester.go 97.95% <100.00%> (+0.02%) ⬆️
go/common/grpc/errors.go 72.34% <0.00%> (-12.77%) ⬇️
go/worker/storage/committee/checkpoint_sync.go 71.58% <0.00%> (-4.80%) ⬇️
go/keymanager/client/client.go 81.41% <0.00%> (-1.77%) ⬇️
go/staking/api/grpc.go 57.98% <0.00%> (-0.85%) ⬇️
go/storage/api/grpc.go 68.28% <0.00%> (ø)
go/storage/mkvs/insert.go 90.41% <0.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd06df2...ca0289d. Read the comment docs.

@pro-wh pro-wh force-pushed the pro-wh/feature/lastretained branch from dca9f12 to ca0289d Compare October 1, 2020 18:37
@pro-wh pro-wh merged commit b448a7c into master Oct 1, 2020
@pro-wh pro-wh deleted the pro-wh/feature/lastretained branch October 1, 2020 18:57
pro-wh added a commit that referenced this pull request Oct 1, 2020
go consensus: add last retained block information
pro-wh added a commit that referenced this pull request Oct 1, 2020
go consensus: add last retained block information
pro-wh added a commit that referenced this pull request Oct 2, 2020
pro-wh added a commit that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:client Category: client interface c:consensus/cometbft Category: CometBFT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants