Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/common/committee: group version should be the epoch block #3347

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Sep 30, 2020

Discovered while testing: #3322

Note: in the other place where we compute current version (runtime client) we already handle this case correctly.

@ptrus ptrus force-pushed the ptrus/fix/group-version-worker branch 2 times, most recently from 2c40939 to 937d9a3 Compare September 30, 2020 14:19
@ptrus ptrus force-pushed the ptrus/fix/group-version-worker branch from 937d9a3 to 5f6599a Compare September 30, 2020 15:57
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #3347 into master will decrease coverage by 0.39%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3347      +/-   ##
==========================================
- Coverage   65.44%   65.04%   -0.40%     
==========================================
  Files         371      371              
  Lines       33151    33154       +3     
==========================================
- Hits        21695    21566     -129     
- Misses       8261     8375     +114     
- Partials     3195     3213      +18     
Impacted Files Coverage Δ
go/worker/common/committee/group.go 77.06% <60.00%> (-0.62%) ⬇️
go/storage/mkvs/checkpoint/checkpointer.go 64.75% <0.00%> (-15.58%) ⬇️
go/worker/storage/service_external.go 40.74% <0.00%> (-11.12%) ⬇️
go/runtime/host/sandbox/sandbox.go 64.96% <0.00%> (-10.63%) ⬇️
go/consensus/tendermint/api/errors.go 90.00% <0.00%> (-10.00%) ⬇️
go/consensus/tendermint/abci/state/state.go 54.54% <0.00%> (-9.10%) ⬇️
go/common/grpc/policy/policy.go 62.12% <0.00%> (-7.58%) ⬇️
go/staking/api/grpc.go 51.26% <0.00%> (-6.73%) ⬇️
go/consensus/tendermint/abci/mux.go 49.90% <0.00%> (-5.07%) ⬇️
go/consensus/tendermint/apps/staking/query.go 35.71% <0.00%> (-4.77%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac64b52...5f6599a. Read the comment docs.

@ptrus ptrus merged commit 0e3aa70 into master Sep 30, 2020
@ptrus ptrus deleted the ptrus/fix/group-version-worker branch September 30, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants