Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make: Properly handle relative paths in common.mk #3345

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

tjanez
Copy link
Member

@tjanez tjanez commented Sep 30, 2020

No description provided.

@tjanez tjanez added the c:ops Category: operations label Sep 30, 2020
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #3345 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3345   +/-   ##
=======================================
  Coverage   65.39%   65.39%           
=======================================
  Files         371      371           
  Lines       33151    33151           
=======================================
  Hits        21680    21680           
- Misses       8267     8280   +13     
+ Partials     3204     3191   -13     
Impacted Files Coverage Δ
go/storage/mkvs/checkpoint/checkpointer.go 64.75% <0.00%> (-15.58%) ⬇️
go/worker/compute/executor/committee/state.go 71.42% <0.00%> (-14.29%) ⬇️
go/common/grpc/policy/policy.go 62.12% <0.00%> (-7.58%) ⬇️
...nsensus/tendermint/apps/staking/signing_rewards.go 20.00% <0.00%> (-5.72%) ⬇️
go/consensus/tendermint/apps/staking/staking.go 50.80% <0.00%> (-3.23%) ⬇️
go/roothash/api/commitment/pool.go 72.48% <0.00%> (-2.63%) ⬇️
go/consensus/tendermint/apps/staking/fees.go 47.82% <0.00%> (-1.45%) ⬇️
go/consensus/tendermint/abci/mux.go 53.09% <0.00%> (-1.13%) ⬇️
go/worker/compute/executor/committee/node.go 63.30% <0.00%> (-1.11%) ⬇️
go/staking/api/grpc.go 57.14% <0.00%> (-0.85%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4e81a9...18db9cb. Read the comment docs.

@tjanez tjanez merged commit 799cef3 into master Sep 30, 2020
@tjanez tjanez deleted the tjanez/make-fix-relpaths branch September 30, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:ops Category: operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants