Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: update to build on macOS #3333

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Conversation

peterjgilbert
Copy link
Contributor

@peterjgilbert peterjgilbert commented Sep 28, 2020

This PR factors out some OS-specific syscall parameters for conditional compilation.

This does not change the fact that macOS is not officially supported by Oasis Core.

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #3333 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3333      +/-   ##
==========================================
+ Coverage   65.21%   65.23%   +0.02%     
==========================================
  Files         371      371              
  Lines       33151    33151              
==========================================
+ Hits        21620    21627       +7     
+ Misses       8339     8323      -16     
- Partials     3192     3201       +9     
Impacted Files Coverage Δ
...o/common/crypto/signature/signers/plugin/plugin.go 57.29% <100.00%> (ø)
go/oasis-node/cmd/common/isatty.go 100.00% <100.00%> (ø)
go/oasis-node/cmd/common/metrics/disk.go 65.38% <0.00%> (-19.24%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 78.94% <0.00%> (-10.53%) ⬇️
go/consensus/tendermint/api/errors.go 90.00% <0.00%> (-10.00%) ⬇️
go/keymanager/client/client.go 81.41% <0.00%> (-4.43%) ⬇️
...n/crypto/signature/signers/memory/memory_signer.go 72.41% <0.00%> (-3.45%) ⬇️
go/worker/common/committee/node.go 74.86% <0.00%> (-2.80%) ⬇️
go/storage/mkvs/lookup.go 72.63% <0.00%> (-2.11%) ⬇️
go/runtime/committee/nodes.go 69.69% <0.00%> (-1.52%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee5041e...a749851. Read the comment docs.

@peterjgilbert peterjgilbert changed the title Update oasis-core to build on macOS go: update to build on macOS Sep 29, 2020
@peterjgilbert peterjgilbert force-pushed the peterjgilbert/feature/darwin branch from f7503a3 to a3b7032 Compare September 29, 2020 03:22
go/common/crypto/signature/signers/plugin/plugin.go Outdated Show resolved Hide resolved
go/common/syscall/syscall_darwin.go Outdated Show resolved Hide resolved
go/common/syscall/syscall_darwin.go Show resolved Hide resolved
go/common/syscall/syscall_linux.go Show resolved Hide resolved
@peterjgilbert peterjgilbert force-pushed the peterjgilbert/feature/darwin branch from a3b7032 to a7d241e Compare September 29, 2020 14:10
@peterjgilbert peterjgilbert force-pushed the peterjgilbert/feature/darwin branch from a7d241e to a749851 Compare September 29, 2020 20:42
@peterjgilbert peterjgilbert merged commit cfc43f8 into master Sep 29, 2020
@peterjgilbert peterjgilbert deleted the peterjgilbert/feature/darwin branch September 29, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants