Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/executor: only remove incoming transactions on finalized round #3332

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Sep 28, 2020

No description provided.

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #3332 into master will increase coverage by 0.11%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3332      +/-   ##
==========================================
+ Coverage   65.18%   65.29%   +0.11%     
==========================================
  Files         371      371              
  Lines       33177    33163      -14     
==========================================
+ Hits        21626    21655      +29     
+ Misses       8350     8297      -53     
- Partials     3201     3211      +10     
Impacted Files Coverage Δ
go/worker/storage/committee/checkpoint_sync.go 80.07% <0.00%> (+0.67%) ⬆️
go/worker/compute/executor/committee/node.go 61.45% <80.00%> (+0.64%) ⬆️
go/runtime/scheduling/simple/incoming_queue.go 95.95% <94.11%> (-0.08%) ⬇️
go/runtime/scheduling/simple/simple.go 78.57% <100.00%> (+13.86%) ⬆️
go/storage/mkvs/db/badger/badger.go 68.27% <100.00%> (ø)
go/oasis-node/cmd/common/metrics/disk.go 65.38% <0.00%> (-19.24%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 78.94% <0.00%> (-10.53%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/state.go 70.00% <0.00%> (-5.00%) ⬇️
go/consensus/tendermint/full/services.go 81.35% <0.00%> (-4.24%) ⬇️
go/storage/mkvs/lookup.go 74.73% <0.00%> (-4.22%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c6a5d4...ec30296. Read the comment docs.

@ptrus ptrus marked this pull request as ready for review September 28, 2020 09:27
@ptrus ptrus force-pushed the ptrus/fix/executor-simplify branch from 888d869 to f9dbdba Compare September 28, 2020 10:21
@ptrus ptrus force-pushed the ptrus/fix/executor-simplify branch from f9dbdba to ec30296 Compare September 28, 2020 10:37
@ptrus ptrus merged commit 4e25e4e into master Sep 28, 2020
@ptrus ptrus deleted the ptrus/fix/executor-simplify branch September 28, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants