Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/p2p: Skip peer authentication for our own messages #3319

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Sep 24, 2020

Fixes: #3318

@ptrus ptrus force-pushed the ptrus/fix/p2p-authentication branch from 9e9068e to 95a04bb Compare September 24, 2020 08:56
@ptrus ptrus force-pushed the ptrus/fix/p2p-authentication branch 2 times, most recently from 02f6920 to 45f920a Compare September 24, 2020 09:06
@ptrus ptrus force-pushed the ptrus/fix/p2p-authentication branch from 45f920a to bdea056 Compare September 24, 2020 09:12
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #3319 into master will increase coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3319      +/-   ##
==========================================
+ Coverage   65.11%   65.31%   +0.20%     
==========================================
  Files         371      371              
  Lines       33044    33045       +1     
==========================================
+ Hits        21516    21584      +68     
+ Misses       8347     8268      -79     
- Partials     3181     3193      +12     
Impacted Files Coverage Δ
go/worker/common/p2p/dispatch.go 74.52% <100.00%> (+0.24%) ⬆️
go/worker/compute/executor/committee/batch.go 63.63% <0.00%> (-18.19%) ⬇️
go/consensus/tendermint/api/errors.go 90.00% <0.00%> (-10.00%) ⬇️
go/consensus/tendermint/full/services.go 77.11% <0.00%> (-4.24%) ⬇️
go/consensus/tendermint/apps/staking/state/gas.go 81.13% <0.00%> (-3.78%) ⬇️
go/worker/common/committee/node.go 74.86% <0.00%> (-2.80%) ⬇️
go/consensus/tendermint/roothash/roothash.go 69.53% <0.00%> (-2.77%) ⬇️
go/storage/mkvs/cache.go 79.14% <0.00%> (-1.90%) ⬇️
go/storage/mkvs/iterator.go 80.57% <0.00%> (-1.44%) ⬇️
go/runtime/committee/client.go 76.41% <0.00%> (-1.42%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00c5edb...bdea056. Read the comment docs.

@ptrus ptrus merged commit c3e4f5e into master Sep 24, 2020
@ptrus ptrus deleted the ptrus/fix/p2p-authentication branch September 24, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P2P Dispatch should always authenticate own messages
2 participants