Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/executor: clear tx queue before returning to committee #3300

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Sep 22, 2020

No description provided.

@ptrus ptrus force-pushed the ptrus/fix/executor-clear-queue branch 2 times, most recently from 6163bf4 to 94f40c8 Compare September 22, 2020 10:02
@ptrus ptrus force-pushed the ptrus/fix/executor-clear-queue branch from 94f40c8 to e00c74c Compare September 22, 2020 10:06
@ptrus ptrus marked this pull request as ready for review September 22, 2020 10:13
@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #3300 into master will increase coverage by 0.09%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3300      +/-   ##
==========================================
+ Coverage   65.15%   65.24%   +0.08%     
==========================================
  Files         371      371              
  Lines       33039    33044       +5     
==========================================
+ Hits        21528    21561      +33     
+ Misses       8309     8299      -10     
+ Partials     3202     3184      -18     
Impacted Files Coverage Δ
go/worker/compute/executor/committee/node.go 61.14% <90.00%> (+0.99%) ⬆️
go/consensus/tendermint/api/errors.go 90.00% <0.00%> (-10.00%) ⬇️
go/storage/mkvs/checkpoint/restorer.go 82.00% <0.00%> (-10.00%) ⬇️
go/consensus/tendermint/apps/beacon/beacon.go 69.49% <0.00%> (-8.48%) ⬇️
go/consensus/tendermint/apps/beacon/state/state.go 53.33% <0.00%> (-6.67%) ⬇️
go/consensus/tendermint/apps/staking/state/gas.go 81.13% <0.00%> (-3.78%) ⬇️
go/worker/storage/committee/checkpoint_sync.go 76.80% <0.00%> (-3.43%) ⬇️
...consensus/tendermint/apps/registry/transactions.go 55.80% <0.00%> (-1.66%) ⬇️
go/runtime/committee/client.go 76.41% <0.00%> (-1.42%) ⬇️
go/consensus/tendermint/full/full.go 60.52% <0.00%> (-0.80%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b57643f...e00c74c. Read the comment docs.

@ptrus ptrus merged commit 4dd069d into master Sep 22, 2020
@ptrus ptrus deleted the ptrus/fix/executor-clear-queue branch September 22, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants