rust: bump serde crates #3294
Merged
rust: bump serde crates #3294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/feature/bump-serde
branch
from
2730a65 to
0a9feaf
Compare
Codecov Report
@@ Coverage Diff @@
## master #3294 +/- ##
==========================================
- Coverage 65.28% 65.23% -0.06%
==========================================
Files 371 371
Lines 33039 33039
==========================================
- Hits 21571 21552 -19
- Misses 8273 8309 +36
+ Partials 3195 3178 -17
Continue to review full report at Codecov.
|
ptrus
force-pushed
the
ptrus/feature/bump-serde
branch
2 times, most recently
from
f998703 to
cddfca5
Compare
ptrus
commented
Sep 21, 2020
| @@ -25,7 +25,6 @@ impl SessionID { | |||
| /// Frame. | |||
| #[derive(Debug, Serialize, Deserialize)] | |||
| pub struct Frame { | |||
| #[serde(with = "serde_bytes")] | |||
There was a problem hiding this comment.
Note: serde_bytes now internally uses serde_bytes::{Serialize,Deserialize} traits, and is missing implementations for fixed sized byte arrays, so we cannot use it here anymore.
However serde_bytes is not even needed here since we implement "byte-array aware" serde serialization and deserialization methods in impl_bytes! anyway.
ptrus
force-pushed
the
ptrus/feature/bump-serde
branch
from
cddfca5 to
fa0bfab
Compare
ptrus
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
Also removes explicit serde_derive crate, now used via the "derive" feature on the serde crate.
ptrus
force-pushed
the
ptrus/feature/bump-serde
branch
from
fa0bfab to
70bdca0
Compare
Yawning
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #3245
TODO:
serde_bytes