Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/consensus/tests: Use same height when comparing GetTransations results #3287

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Sep 18, 2020

No description provided.

Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, should fix the flaky test :-)

@kostko kostko added the c:testing Category: testing label Sep 18, 2020
@ptrus ptrus force-pushed the ptrus/fix/consensus-test branch from bc1f9ac to d89fa05 Compare September 18, 2020 08:02
@ptrus ptrus marked this pull request as ready for review September 18, 2020 08:03
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #3287 into master will decrease coverage by 2.37%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3287      +/-   ##
==========================================
- Coverage   67.75%   65.38%   -2.38%     
==========================================
  Files         371      371              
  Lines       36888    32936    -3952     
==========================================
- Hits        24995    21534    -3461     
+ Misses       8704     8227     -477     
+ Partials     3189     3175      -14     
Impacted Files Coverage Δ
go/consensus/tests/tester.go 97.93% <100.00%> (-0.11%) ⬇️
go/upgrade/api/api.go 45.45% <0.00%> (-17.05%) ⬇️
go/runtime/transaction/rwset.go 28.57% <0.00%> (-16.89%) ⬇️
go/genesis/api/api.go 55.55% <0.00%> (-13.68%) ⬇️
go/common/grpc/writer.go 60.00% <0.00%> (-11.43%) ⬇️
go/worker/common/p2p/error/error.go 60.00% <0.00%> (-11.43%) ⬇️
go/storage/mkvs/checkpoint/restorer.go 82.00% <0.00%> (-10.99%) ⬇️
go/consensus/tendermint/apps/beacon/query.go 71.42% <0.00%> (-10.39%) ⬇️
go/beacon/api/api.go 50.00% <0.00%> (-10.00%) ⬇️
go/staking/api/rewards.go 50.00% <0.00%> (-10.00%) ⬇️
... and 355 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1348d9...5b8761e. Read the comment docs.

@ptrus ptrus force-pushed the ptrus/fix/consensus-test branch from d89fa05 to 5b8761e Compare September 18, 2020 08:24
@ptrus
Copy link
Member Author

ptrus commented Sep 18, 2020

Node coverage decreased since apparently codecov stopped counting function definition lines:
see: this commit report vs master report

@ptrus ptrus merged commit e2edc04 into master Sep 18, 2020
@ptrus ptrus deleted the ptrus/fix/consensus-test branch September 18, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:testing Category: testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants