Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/transaction: Ensure consistent batch order indices #3248

Merged
merged 3 commits into from
Sep 8, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Sep 4, 2020

No description provided.

@kostko kostko added c:runtime Category: runtime c:bug Category: bug labels Sep 4, 2020
@kostko kostko force-pushed the kostko/fix/rt-txns-batchorder branch from fd02403 to 168a5b0 Compare September 4, 2020 20:21
@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #3248 into master will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3248      +/-   ##
==========================================
+ Coverage   67.47%   67.61%   +0.14%     
==========================================
  Files         370      370              
  Lines       36327    36330       +3     
==========================================
+ Hits        24513    24566      +53     
+ Misses       8638     8598      -40     
+ Partials     3176     3166      -10     
Impacted Files Coverage Δ
go/runtime/transaction/transaction.go 78.40% <100.00%> (+2.68%) ⬆️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
go/storage/api/root_cache.go 74.60% <0.00%> (-6.35%) ⬇️
go/keymanager/client/client.go 82.64% <0.00%> (-5.79%) ⬇️
...n/crypto/signature/signers/memory/memory_signer.go 71.42% <0.00%> (-4.77%) ⬇️
go/worker/common/p2p/dispatch.go 76.52% <0.00%> (-4.35%) ⬇️
go/storage/mkvs/tree.go 89.28% <0.00%> (-3.58%) ⬇️
go/storage/mkvs/insert.go 87.75% <0.00%> (-2.73%) ⬇️
go/staking/api/grpc.go 51.93% <0.00%> (-2.33%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99f3bce...3cbedf7. Read the comment docs.

@kostko kostko force-pushed the kostko/fix/rt-txns-batchorder branch from 168a5b0 to 3cbedf7 Compare September 7, 2020 07:45
@kostko kostko merged commit 581ecee into master Sep 8, 2020
@kostko kostko deleted the kostko/fix/rt-txns-batchorder branch September 8, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:runtime Category: runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants