Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: Unify CLI tools' version display #3233

Merged
merged 2 commits into from
Sep 4, 2020
Merged

Conversation

tjanez
Copy link
Member

@tjanez tjanez commented Sep 3, 2020

No description provided.

@tjanez tjanez added the c:cli Category: command line interface label Sep 3, 2020
@tjanez tjanez force-pushed the tjanez/unify-version-display branch from 2946c02 to 79e8c75 Compare September 4, 2020 07:33
@tjanez tjanez force-pushed the tjanez/unify-version-display branch from 79e8c75 to 7c25faa Compare September 4, 2020 08:05
@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #3233 into master will increase coverage by 0.11%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3233      +/-   ##
==========================================
+ Coverage   67.47%   67.58%   +0.11%     
==========================================
  Files         370      370              
  Lines       36379    36386       +7     
==========================================
+ Hits        24546    24591      +45     
+ Misses       8662     8629      -33     
+ Partials     3171     3166       -5     
Impacted Files Coverage Δ
go/oasis-node/cmd/common/common.go 54.54% <85.71%> (+1.60%) ⬆️
go/consensus/tendermint/api/errors.go 86.66% <0.00%> (-13.34%) ⬇️
go/runtime/scheduling/simple/simple.go 79.68% <0.00%> (-6.25%) ⬇️
go/keymanager/client/client.go 82.64% <0.00%> (-5.79%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/state.go 78.72% <0.00%> (-4.26%) ⬇️
go/storage/mkvs/insert.go 87.75% <0.00%> (-4.09%) ⬇️
go/storage/mkvs/tree.go 89.28% <0.00%> (-3.58%) ⬇️
go/storage/api/root_cache.go 77.77% <0.00%> (-3.18%) ⬇️
go/runtime/committee/nodes.go 76.47% <0.00%> (-1.97%) ⬇️
go/worker/common/committee/group.go 79.24% <0.00%> (-1.89%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 589bea6...7c25faa. Read the comment docs.

@tjanez tjanez merged commit 24c7327 into master Sep 4, 2020
@tjanez tjanez deleted the tjanez/unify-version-display branch September 4, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:cli Category: command line interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants