go/roothash: Make the parent block check earlier

[kostko]

No description provided.

[codecov]

Codecov Report

Merging #3206 into master will increase coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3206      +/-   ##
==========================================
+ Coverage   67.16%   67.42%   +0.26%     
==========================================
  Files         371      371              
  Lines       36107    36107              
==========================================
+ Hits        24250    24344      +94     
+ Misses       8715     8627      -88     
+ Partials     3142     3136       -6     

Impacted Files	Coverage Δ
go/roothash/api/commitment/pool.go	73.80% <100.00%> (ø)
go/consensus/tendermint/api/api.go	77.65% <0.00%> (-9.58%)	⬇️
go/consensus/tendermint/abci/state/state.go	61.53% <0.00%> (-7.70%)	⬇️
go/common/grpc/policy/policy.go	64.38% <0.00%> (-6.85%)	⬇️
go/worker/storage/service_external.go	51.47% <0.00%> (-5.89%)	⬇️
go/worker/common/p2p/dispatch.go	76.31% <0.00%> (-4.39%)	⬇️
go/runtime/tagindexer/tagindexer.go	68.47% <0.00%> (-4.35%)	⬇️
go/storage/mkvs/iterator.go	83.12% <0.00%> (-2.50%)	⬇️
go/runtime/transaction/transaction.go	75.72% <0.00%> (-2.32%)	⬇️
go/storage/mkvs/lookup.go	73.46% <0.00%> (-2.05%)	⬇️
... and 30 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89225d6...f4679db. Read the comment docs.

[ptrus]

This just makes moves the block check to before" Verify RAK-attestation" right? (which does makes sense)

[kostko]

This just makes moves the block check to before" Verify RAK-attestation" right? (which does makes sense)

Yeah, the check is less expensive than descriptor lookup and the RAK signature verifications, so it makes sense to reject early.