Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/oasis-test-runner: Fix e2e/consensus-state-sync scenario #3194

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Aug 18, 2020

Instead of terminating the validator-to-be-synced immediately and restarting
it later, do not even start it. Early stopping could result in state that
prevents proper state sync later.

Instead of terminating the validator-to-be-synced immediately and restarting
it later, do not even start it. Early stopping could result in state that
prevents proper state sync later.
@kostko kostko force-pushed the kostko/fix/e2e-statesync-val branch from b51576d to 73ee743 Compare August 18, 2020 08:48
@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #3194 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3194      +/-   ##
==========================================
- Coverage   67.92%   67.88%   -0.05%     
==========================================
  Files         380      380              
  Lines       36627    36627              
==========================================
- Hits        24879    24863      -16     
- Misses       8525     8594      +69     
+ Partials     3223     3170      -53     
Impacted Files Coverage Δ
go/consensus/tendermint/full/statesync.go 0.00% <0.00%> (-64.07%) ⬇️
go/consensus/tendermint/light/client.go 0.00% <0.00%> (-46.35%) ⬇️
go/storage/mkvs/checkpoint/checkpoint.go 86.66% <0.00%> (-13.34%) ⬇️
go/consensus/tendermint/api/api.go 77.65% <0.00%> (-9.58%) ⬇️
go/common/grpc/policy/policy.go 64.38% <0.00%> (-6.85%) ⬇️
go/storage/api/root_cache.go 74.60% <0.00%> (-6.35%) ⬇️
go/consensus/tendermint/abci/mux.go 54.88% <0.00%> (-5.06%) ⬇️
go/storage/metrics.go 81.08% <0.00%> (-4.06%) ⬇️
go/storage/mkvs/tree.go 89.28% <0.00%> (-3.58%) ⬇️
go/storage/mkvs/insert.go 87.75% <0.00%> (-2.73%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63ea1a9...73ee743. Read the comment docs.

@kostko kostko merged commit f7ea9cd into master Aug 18, 2020
@kostko kostko deleted the kostko/fix/e2e-statesync-val branch August 18, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants