go/roothash: Drop support for multiple committees #3179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
added
c:storage
kostko
force-pushed
the
kostko/feature/merge-remove-multicomm
branch
from
c50b525 to
d953945
Compare
kostko
force-pushed
the
kostko/feature/merge-remove-multicomm
branch
5 times, most recently
from
cb74419 to
c28c9bc
Compare
kostko
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3179 +/- ##
==========================================
- Coverage 68.37% 67.92% -0.45%
==========================================
Files 386 380 -6
Lines 37962 36558 -1404
==========================================
- Hits 25957 24833 -1124
+ Misses 8699 8496 -203
+ Partials 3306 3229 -77
Continue to review full report at Codecov.
|
kostko
force-pushed
the
kostko/feature/merge-remove-multicomm
branch
from
c28c9bc to
0109e60
Compare
pro-wh
reviewed
Aug 11, 2020
kostko
force-pushed
the
kostko/feature/merge-remove-multicomm
branch
from
f1a6dff to
c6f88c2
Compare
pro-wh
reviewed
Aug 11, 2020
pro-wh
reviewed
Aug 11, 2020
Since there is currently no transaction scheduler implementation which would support multiple committees, there is no sense in the merge node to try to support such cases as it could be a source of bugs. Additionally it results in extra round trips to storage nodes due to the Merge operation which in case of a single committee does not do anything. The merge node is also the only client for the Merge* storage operations, so they can just be removed in order to reduce the exposed API surface.
kostko
force-pushed
the
kostko/feature/merge-remove-multicomm
branch
3 times, most recently
from
a935be1 to
fc55eb7
Compare
ptrus
reviewed
Aug 12, 2020
Since P2P message delivery is async, the roundCtx could be for the previous round and so could get cancelled prematurely. Introduce a timeout instead.
kostko
force-pushed
the
kostko/feature/merge-remove-multicomm
branch
from
fc55eb7 to
2209ffe
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is currently no transaction scheduler implementation which would
support multiple committees, there is no sense in having the merge node as it
could be a source of bugs.
The merge node is also the only client for the Merge* storage operations, so
they can just be removed in order to reduce the exposed API surface.