Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: Reduce maximum RHP message size #3139

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Jul 29, 2020

Fixes #2213

Message size is reduced based on benchmark metrics where messages never exceeded 3 MiB even with large batches.

Also enforces maximum batch sizes at compute nodes.

@kostko kostko force-pushed the kostko/fix/reduce-rhp-codec-limit branch from e1ba093 to 8dbaf39 Compare July 29, 2020 08:44
@kostko kostko marked this pull request as ready for review July 29, 2020 08:44
@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #3139 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3139      +/-   ##
==========================================
+ Coverage   68.91%   68.98%   +0.06%     
==========================================
  Files         375      375              
  Lines       37050    37060      +10     
==========================================
+ Hits        25533    25565      +32     
+ Misses       8268     8251      -17     
+ Partials     3249     3244       -5     
Impacted Files Coverage Δ
go/common/cbor/codec.go 78.37% <ø> (ø)
go/runtime/transaction/transaction.go 78.03% <100.00%> (+3.48%) ⬆️
go/worker/compute/executor/committee/batch.go 69.23% <100.00%> (ø)
go/worker/compute/executor/committee/node.go 65.10% <100.00%> (+1.07%) ⬆️
go/storage/mkvs/tree.go 89.28% <0.00%> (-3.58%) ⬇️
go/worker/common/committee/node.go 75.70% <0.00%> (-2.83%) ⬇️
go/runtime/client/watcher.go 73.84% <0.00%> (-1.54%) ⬇️
go/consensus/tendermint/roothash/roothash.go 72.72% <0.00%> (-1.38%) ⬇️
go/storage/client/client.go 74.16% <0.00%> (-1.25%) ⬇️
go/worker/compute/txnscheduler/committee/node.go 64.86% <0.00%> (-1.21%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ab5ad2...8dbaf39. Read the comment docs.

@kostko kostko merged commit 683eb0d into master Jul 29, 2020
@kostko kostko deleted the kostko/fix/reduce-rhp-codec-limit branch July 29, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EXT-SEC-AUDIT] Excessive size limit of Ekiden runtime messages can result in fatal out-of-memory errors
2 participants