Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/common: Treat stale unauthorized peer error as permanent #3133

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Jul 27, 2020

If the message's group version indicates that the message is stale and an
authorization check fails, treat the error as permanent as a stale message will
never become valid.

@kostko kostko force-pushed the kostko/fix/p2p-auth-perm branch from af331fd to 03727e8 Compare July 27, 2020 11:53
@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #3133 into master will decrease coverage by 0.25%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3133      +/-   ##
==========================================
- Coverage   69.04%   68.78%   -0.26%     
==========================================
  Files         375      375              
  Lines       37047    37050       +3     
==========================================
- Hits        25579    25486      -93     
- Misses       8241     8345     +104     
+ Partials     3227     3219       -8     
Impacted Files Coverage Δ
go/worker/common/committee/group.go 81.75% <81.81%> (+0.86%) ⬆️
go/worker/common/p2p/dispatch.go 71.96% <100.00%> (ø)
go/runtime/host/sandbox/sandbox.go 67.28% <0.00%> (-10.04%) ⬇️
go/consensus/tendermint/apps/scheduler/query.go 71.05% <0.00%> (-7.90%) ⬇️
go/consensus/tendermint/epochtime/epochtime.go 78.78% <0.00%> (-7.58%) ⬇️
go/registry/api/grpc.go 36.08% <0.00%> (-7.34%) ⬇️
go/consensus/tendermint/apps/staking/query.go 49.09% <0.00%> (-7.28%) ⬇️
go/staking/api/grpc.go 53.76% <0.00%> (-5.92%) ⬇️
go/worker/common/committee/runtime_host.go 65.71% <0.00%> (-4.77%) ⬇️
go/runtime/tagindexer/tagindexer.go 68.47% <0.00%> (-4.35%) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a891dd3...7edc283. Read the comment docs.

If the message's group version indicates that the message is stale and an
authorization check fails, treat the error as permanent as a stale message will
never become valid.
@kostko kostko force-pushed the kostko/fix/p2p-auth-perm branch from 03727e8 to 7edc283 Compare July 28, 2020 08:30
@kostko kostko marked this pull request as ready for review July 28, 2020 08:30
@kostko kostko merged commit 22002f0 into master Jul 28, 2020
@kostko kostko deleted the kostko/fix/p2p-auth-perm branch July 28, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants