Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/common/grpc: Client verbose logging and metrics #3121

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jul 21, 2020

  • gRPC global logger is now set to oasis logger even if the code using it doesn't initialize any servers, but only uses gRPC clients (and has grpc verbose logging enabled). Before this happened only if a gRPC server was created:
    • this mostly affects test binaries (such as workloads) which do use gRPC client, but don't initialize any servers.
  • adds gRPC client logging interceptors
    • only had these for servers
  • adds gRPC client instrumentation
    • only had gRPC metrics for servers

@ptrus ptrus force-pushed the ptrus/feature/grpc-client-logging branch 3 times, most recently from 6600b5f to 0989781 Compare July 21, 2020 13:15
@ptrus ptrus force-pushed the ptrus/feature/grpc-client-logging branch from 0989781 to 96542d3 Compare July 21, 2020 13:18
@ptrus ptrus marked this pull request as ready for review July 21, 2020 13:47
@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #3121 into master will increase coverage by 0.08%.
The diff coverage is 91.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3121      +/-   ##
==========================================
+ Coverage   68.56%   68.65%   +0.08%     
==========================================
  Files         375      375              
  Lines       36962    37037      +75     
==========================================
+ Hits        25342    25426      +84     
+ Misses       8390     8376      -14     
- Partials     3230     3235       +5     
Impacted Files Coverage Δ
go/common/grpc/grpc.go 85.01% <91.25%> (+1.61%) ⬆️
go/oasis-node/cmd/common/grpc/grpc.go 85.41% <100.00%> (+0.31%) ⬆️
go/consensus/tendermint/api/errors.go 86.66% <0.00%> (-13.34%) ⬇️
go/storage/metrics.go 81.52% <0.00%> (-6.53%) ⬇️
go/keymanager/client/client.go 82.64% <0.00%> (-5.79%) ⬇️
...sensus/tendermint/epochtime_mock/epochtime_mock.go 70.63% <0.00%> (-5.56%) ⬇️
go/worker/common/committee/runtime_host.go 65.71% <0.00%> (-4.77%) ⬇️
go/storage/api/root_cache.go 72.41% <0.00%> (-4.60%) ⬇️
go/consensus/tendermint/apps/staking/state/gas.go 77.58% <0.00%> (-3.45%) ⬇️
go/storage/database/database.go 72.26% <0.00%> (-3.37%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57f4c8...96542d3. Read the comment docs.

@ptrus ptrus merged commit 5045419 into master Jul 21, 2020
@ptrus ptrus deleted the ptrus/feature/grpc-client-logging branch July 21, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants