go/oasis-node/cmd/common: ExportEntity should use the entity ctor #3117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yawning
force-pushed
the
yawning/fix/trivial
branch
from
b3a41e3 to
4325e98
Compare
kostko
approved these changes
Jul 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #3117 +/- ##
=========================================
Coverage ? 68.54%
=========================================
Files ? 374
Lines ? 36895
Branches ? 0
=========================================
Hits ? 25291
Misses ? 8357
Partials ? 3247
Continue to review full report at Codecov.
|
Yawning
force-pushed
the
yawning/fix/trivial
branch
2 times, most recently
from
07381e3 to
6538cbd
Compare
Instead of using an entity populated with the zero values and a manually filled in public key, use the entity constructor that can fill in sensible values for things like the version.
Yawning
force-pushed
the
yawning/fix/trivial
branch
from
6538cbd to
4cea752
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using an entity populated with the zero values and a manually
filled in public key, use the entity constructor that can fill in
sensible values for things like the version.
Rescued from #3094