Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/oasis-node/cmd: Remove retry functionality from staking CLI commands #3113

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

tjanez
Copy link
Member

@tjanez tjanez commented Jul 17, 2020

As mentioned #3111 (comment), the retry functionality is not needed since the staking client waits for a response from the gRPC server.

The retry functionality is not needed since the staking client waits for
a response from the gRPC server.
@tjanez tjanez added c:breaking/consensus Category: breaking consensus changes c:staking Category: staking c:cli Category: command line interface labels Jul 17, 2020
@tjanez tjanez self-assigned this Jul 17, 2020
@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #3113 into master will increase coverage by 0.16%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3113      +/-   ##
==========================================
+ Coverage   68.36%   68.52%   +0.16%     
==========================================
  Files         372      372              
  Lines       36910    36882      -28     
==========================================
+ Hits        25234    25275      +41     
+ Misses       8436     8352      -84     
- Partials     3240     3255      +15     
Impacted Files Coverage Δ
go/oasis-node/cmd/common/flags/flags.go 94.11% <ø> (-0.62%) ⬇️
go/oasis-node/cmd/stake/account.go 56.98% <ø> (-0.24%) ⬇️
go/oasis-node/cmd/stake/stake.go 51.66% <25.00%> (-17.57%) ⬇️
go/runtime/host/protocol/connection.go 61.38% <0.00%> (-4.64%) ⬇️
go/runtime/tagindexer/tagindexer.go 68.47% <0.00%> (-4.35%) ⬇️
go/worker/keymanager/handler.go 60.37% <0.00%> (-3.78%) ⬇️
go/storage/metrics.go 71.73% <0.00%> (-3.27%) ⬇️
go/roothash/api/commitment/pool.go 70.54% <0.00%> (-3.25%) ⬇️
go/storage/mkvs/iterator.go 81.87% <0.00%> (-2.50%) ⬇️
go/runtime/transaction/transaction.go 74.54% <0.00%> (-2.43%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3263a4d...4630569. Read the comment docs.

@tjanez tjanez merged commit c28bc0c into master Jul 17, 2020
@tjanez tjanez deleted the tjanez/cli-remove-retries branch July 17, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:breaking/consensus Category: breaking consensus changes c:cli Category: command line interface c:staking Category: staking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants