go/oasis-test-runner: Refactor code to refer to scenario(s) consistently #3108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjanez
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
tjanez
force-pushed
the
tjanez/test-runner-consistency
branch
3 times, most recently
from
e81f7d7 to
e0437c7
Compare
|
Also fix: |
kostko
reviewed
Jul 14, 2020
tjanez
force-pushed
the
tjanez/test-runner-parallel-bug
branch
2 times, most recently
from
2058d6f to
4e244df
Compare
go/oasis-test-runner/cmd: Rename --test flag to --scenario (-s for short version) for consistency. go/oasis-test-runner/env: - Rename TestInstanceInfo type to ScenarioInstanceInfo and its Test field to Scenario for consistency. - Rename Env's TestInfo() and WriteTestInfo() methods to ScenarioInfo() and WriteScenarioInfo() for consistency. go/oasis-node/cmd/common/metrics: Use "scenario" metrics label instead of "test" for consistency.
tjanez
force-pushed
the
tjanez/test-runner-consistency
branch
from
e0437c7 to
f7f6dc5
Compare
Done. |
Codecov Report
@@ Coverage Diff @@
## master #3108 +/- ##
==========================================
- Coverage 68.22% 68.18% -0.05%
==========================================
Files 372 372
Lines 36896 36896
==========================================
- Hits 25174 25156 -18
- Misses 8465 8474 +9
- Partials 3257 3266 +9
Continue to review full report at Codecov.
|
Yawning
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go/oasis-test-runner/cmd: Rename
--testflag to--scenarioflag (-sfor short version) for consistency.go/oasis-test-runner/env:
TestInstanceInfotype toScenarioInstanceInfoand itsTestfield toScenariofield for consistency.Env'sTestInfo()andWriteTestInfo()methods toScenarioInfo()andWriteScenarioInfo()for consistency.go/oasis-node/cmd/common/metrics: Use "scenario" metrics label instead of "test" for consistency.