Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: Cleanup some runtime host protocol messages #3055

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 26, 2020

Noticed while writing docs in #3054.

The major change is removing state root parameters from RPC messages as these are unused and don't make sense.

@kostko kostko force-pushed the kostko/feature/rhp-cleanup branch from 9f0fbb9 to 91e9c94 Compare June 26, 2020 09:55
@kostko kostko force-pushed the kostko/feature/rhp-cleanup branch from 91e9c94 to 1e0d475 Compare June 26, 2020 10:07
@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #3055 into master will decrease coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3055      +/-   ##
==========================================
- Coverage   68.47%   68.24%   -0.24%     
==========================================
  Files         372      372              
  Lines       36444    36441       -3     
==========================================
- Hits        24955    24869      -86     
- Misses       8294     8362      +68     
- Partials     3195     3210      +15     
Impacted Files Coverage Δ
go/common/version/version.go 84.00% <ø> (ø)
go/runtime/host/protocol/types.go 50.00% <ø> (ø)
go/worker/keymanager/init.go 69.56% <ø> (-0.65%) ⬇️
go/worker/keymanager/worker.go 67.16% <100.00%> (-0.20%) ⬇️
go/consensus/tendermint/api/errors.go 86.66% <0.00%> (-13.34%) ⬇️
go/consensus/tendermint/api/api.go 79.41% <0.00%> (-11.77%) ⬇️
go/worker/compute/executor/committee/state.go 74.07% <0.00%> (-11.12%) ⬇️
go/consensus/tendermint/apps/roothash/query.go 68.42% <0.00%> (-10.53%) ⬇️
...ompute/txnscheduler/algorithm/batching/batching.go 78.66% <0.00%> (-6.67%) ⬇️
go/storage/metrics.go 71.73% <0.00%> (-6.53%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 925b7f2...1e0d475. Read the comment docs.

@kostko kostko merged commit 8cb0b36 into master Jun 26, 2020
@kostko kostko deleted the kostko/feature/rhp-cleanup branch June 26, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants